Added logitnormal distribution#23
Merged
aloctavodia merged 2 commits intopymc-devs:mainfrom Jan 14, 2026
Merged
Conversation
aloctavodia
reviewed
Jan 14, 2026
| return pt.sigmoid(y) | ||
|
|
||
|
|
||
| def mean(mu, sigma): |
Member
There was a problem hiding this comment.
In helper.py, we have functions to numerically compute moments for discrete distributions. We should move this and other methods there, so we can reuse them for other distributions. In preliz, distributions has a xvals method https://github.com/arviz-devs/preliz/blob/28bbd018963cbc010d3f13e62124eb4653ec1459/preliz/distributions/distributions.py#L507 that we used for plotting or, in this cas,e to get a reasonable range of values to evaluate some functions. We could have something similar here.
Member
Author
There was a problem hiding this comment.
I ported a few things over to helper.py. Let me know what you think.
aloctavodia
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logit-normal and associated tests (test against empirical)