Conversation
Let's put the `uv` on PATH question aside, and fix #2663. This change ensures that the PATH entries added by Github when you request `shell: bash` don't make it into the pwsh environment. It also keeps the uv binary on PATH if installed via `extras:`. Would love to get this fixed soon, then we can figure out the right approach regarding `uv` discovery.
Cherry-picked from #2718 and modified so we can test the action.yml file
joerick
force-pushed
the
path-mangling
branch
from
1581963 to
7649dd0
Compare
Contributor
Author
|
Contributor
Author
|
how does this look to you @henryiii? |
henryiii
approved these changes
Feb 2, 2026
Contributor
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
We can start with this.
kkraus14
added a commit
to kkraus14/cuda-python
that referenced
this pull request
Feb 19, 2026
cibuildwheel v3.3.x has a PATH mangling bug on Windows that causes Git's /usr/bin/link.exe to shadow MSVC's linker (pypa/cibuildwheel#2663). The fix (pypa/cibuildwheel#2723) is merged but not yet released. Downgrade to v3.2.1 which does not have the bug, removing all the workarounds: DISTUTILS_USE_SDK=1, CIBW_ENVIRONMENT_PASS_WINDOWS for MSVC vars, and the link.exe rename hack. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's put the
uvon PATH question aside, and fix #2663.This change ensures that the PATH entries added by Github when you request
shell: bashdon't make it into the pwsh environment. It also keeps the uv binary on PATH if installed viaextras:.Would love to get this fixed soon, then we can figure out the right approach regarding
uvdiscovery.