fix: switch to python-discovery#2196
Merged
cjames23 merged 3 commits intopypa:masterfrom Feb 26, 2026
Merged
Conversation
|
the test failiures appear to be unrelated to the changes in the PR |
cjames23
approved these changes
Feb 26, 2026
Member
cjames23
left a comment
cjames23
left a comment
There was a problem hiding this comment.
LGTM! Thanks for jumping on this!
Contributor
Author
|
np! btw, no idea why the “Allow edits and access to secrets by maintainers” was off, I actually really prefer when maintainers can edit my forks. |
|
Any chance we can get a rapid one-off release for this? It has broken a lot of CI pipelines, and it would be much easier if there was a release to resolve this, instead of having to pin a version of virtualenv in all projects using hatch. |
ofek
reviewed
Feb 26, 2026
| finally: | ||
| virtualenv_discovery.propose_interpreters = propose_interpreters | ||
| python_info = python_discovery.get_interpreter( | ||
| python_version, (), env=self.get_interpreter_resolver_env(), predicate=self._interpreter_is_compatible |
Contributor
Author
There was a problem hiding this comment.
Thanks to @gaborbernat’s super fast response!
Sometimes all you have to do is ask. If you can think of any other monkey patching done in the code base, maybe it’s a good time to ask the relevant projects to add these respective features?
4 tasks
R7L208
added a commit
to databrickslabs/tempo
that referenced
this pull request
Mar 3, 2026
The lint-and-check CI job fails because virtualenv 21.0.0 removed the propose_interpreters API that hatch 1.14.2 relies on. Hatch 1.16.5 (pypa/hatch#2196) fixes this by switching to the python-discovery package. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tnixon
pushed a commit
to databrickslabs/tempo
that referenced
this pull request
Mar 3, 2026
* Add test for show() k parameter to verify per-series row limiting Adds test_show_k_2 which calls show(n=20, k=2) on a TSDF with 4 rows per series, verifying that only the 2 most recent rows per series are returned. This exercises the k parameter path that was previously only tested for the error case (k > n). Closes #326 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Upgrade hatch to 1.16.5 to fix virtualenv 21.0.0 incompatibility The lint-and-check CI job fails because virtualenv 21.0.0 removed the propose_interpreters API that hatch 1.14.2 relies on. Hatch 1.16.5 (pypa/hatch#2196) fixes this by switching to the python-discovery package. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Revert hatch 1.16.5, pin virtualenv<21 to fix Python 3.9 CI Hatch 1.16.5 requires Python >=3.10, breaking CI for DBR 11.3/12.2 (Python 3.9). Revert to hatch 1.14.2 and pin virtualenv<21 to avoid the removed API in virtualenv 21.0.0 (matching PR #454). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add missing test data entry for test_show_k_2 The test was failing in CI because the test_show_k_2 entry was missing from tsdf_tests.json. Add the init data reference matching other test_show_* tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2193 using public APIs only