Fix RHS marker-variable version comparisons#1112
Fix RHS marker-variable version comparisons#1112SergioChan wants to merge 4 commits intopypa:mainfrom
Conversation
|
Correction: the previous comment was malformed by shell interpolation. Clean results below. I reproduced locally against this PR branch:
So the earlier failing matrix run does not reproduce locally for me. I also attempted to rerun the workflow from CLI, but got: "run 22829736894 cannot be rerun; its workflow file may be broken". If maintainers can rerun checks from repo context and share a concrete failing job/log, I can follow up quickly. |
|
I don't understand what you mean, linting and coverage are both failing. |
|
Pushed a follow-up commit () to address CI failures:\n\n- adds to cover the passthrough branch (line that was missing for coverage)\n- keeps the functional fix unchanged\n\nThis should resolve the coverage gate that was failing across matrix jobs. |
|
Correction to previous comment (shell ate backticks): follow-up commit ccb3644 adds test_swap_op_unknown_operator_passthrough to cover the _swap_op passthrough branch that coverage flagged. Functional behavior of the fix is unchanged. |
|
Pushed a follow-up commit to address the changes reported by CI in (same hunk shown in the failed lint log).\n\nI wasn't able to run the full project nox matrix in this environment, but this commit is scoped to the formatter diff from the failing check. |
|
Pushed a follow-up commit to apply the formatter changes from the failing lint check in markers.py. This commit is intentionally minimal and only includes the ruff-format hunk reported by CI. |
|
Pushed follow-up commit 9ac8110 to address the current failure ( attr-defined on import in tests). What changed:
Validation run locally:
no tests ran in 0.00s ✅ (1 passed) I couldn’t run the full pre-commit/nox lint stack end-to-end in this environment because one hook install step needs external network access during setup, but this change is minimal and targeted to the exact failing mypy check. |
|
Correction: previous comment was malformed by shell quoting. Clean update below. Pushed follow-up commit 9ac8110 to address the current What changed:
Validation run locally:
I could not run the full pre-commit/nox lint stack end-to-end in this environment because one hook install step needs external network access during setup, but this change is minimal and targeted to the exact failing mypy check. |
Summary
'3.13.*' == python_full_version)python_full_version == '3.13.*'Testing
uv run pytest tests/test_markers.pyRelated