Print more user friendly error when --python version not found#1171
Merged
gaborbernat merged 12 commits intopypa:mainfrom Jan 3, 2024
Merged
Print more user friendly error when --python version not found#1171gaborbernat merged 12 commits intopypa:mainfrom
gaborbernat merged 12 commits intopypa:mainfrom
Conversation
Contributor
Author
Windows was not covered, should be fixed now. |
Co-authored-by: chrysle <fritzihab@posteo.de>
for more information, see https://pre-commit.ci
Contributor
|
Indentation never works with those suggestions :-( |
Contributor
Author
Yeah that would be too easy. Does the message look fine to you now? I got rid of the newline as it is stripped by pipx_wrap anyways. Looks like this now: |
chrysle
reviewed
Jan 2, 2024
chrysle
approved these changes
Jan 3, 2024
Contributor
chrysle
left a comment
There was a problem hiding this comment.
Thanks! Unfortunately, one release chases the other these days...
I'm afraid you'll have to rebase once more.
gaborbernat
approved these changes
Jan 3, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
Resolves #1089
Capture FileNotFound error during the install command and exit with a meaningful error message if it indicates that the provided python version was not found.
I think it would actually be nice to do the handling in venv.create_venv which is where the error surfaces. This would mean that the handling is uniform for all places that use this functionality (commands/run, commands/common, commands/install), bit it would also introduce a return value to this function.
def create_venv(...) -> None:->def create_venv(...) -> EXIT_CODE_OK | EXIT_CODE_SPECIFIED_PYTHON_EXECUTABLE_NOT_FOUND:If that's desired I'm happy to change the code accordingly.
Test plan
Tested by running
nox -s tests-3.12