Skip to content

Validate package(s) argument should not be path(s).#1363

Merged
dukecat0 merged 4 commits intopypa:mainfrom
huxuan:xuan.hu/package_is_abspath
Apr 28, 2024
Merged

Validate package(s) argument should not be path(s).#1363
dukecat0 merged 4 commits intopypa:mainfrom
huxuan:xuan.hu/package_is_abspath

Conversation

@huxuan
Copy link
Member

@huxuan huxuan commented Apr 23, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Fix #1354

Test plan

Tested by running

# command(s) to exercise these changes
nox -s tests

@huxuan huxuan marked this pull request as ready for review April 23, 2024 22:51
uranusjr
uranusjr previously approved these changes Apr 24, 2024
@huxuan huxuan force-pushed the xuan.hu/package_is_abspath branch 3 times, most recently from 6035595 to a754a89 Compare April 26, 2024 13:47
@huxuan huxuan force-pushed the xuan.hu/package_is_abspath branch from 2deca1b to 934d394 Compare April 27, 2024 19:25
@huxuan huxuan requested review from chrysle and dukecat0 April 27, 2024 19:46
dukecat0
dukecat0 previously approved these changes Apr 28, 2024
@huxuan huxuan force-pushed the xuan.hu/package_is_abspath branch 2 times, most recently from 5bcbd02 to 96af17f Compare April 28, 2024 06:52
huxuan and others added 4 commits April 28, 2024 15:50
Co-authored-by: Jason Lam <meowmeowcat1211@gmail.com>
Co-authored-by: chrysle <fritzihab@posteo.de>
@huxuan huxuan force-pushed the xuan.hu/package_is_abspath branch from 96af17f to d821db6 Compare April 28, 2024 07:50
@dukecat0 dukecat0 changed the title Validate package(s) argument should not be absolute path(s). Validate package(s) argument should not be path(s). Apr 28, 2024
@dukecat0 dukecat0 merged commit cb65d0a into pypa:main Apr 28, 2024
@dukecat0
Copy link
Member

Thanks!

@huxuan huxuan deleted the xuan.hu/package_is_abspath branch April 30, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Virtual Environment location is invalid when passing an absolute path

4 participants