Fix --system-site-packages for upgrade --install#1378
Conversation
chrysle
reviewed
Apr 28, 2024
Co-authored-by: chrysle <fritzihab@posteo.de>
chrysle
approved these changes
Apr 29, 2024
--system-site-package for upgrade --install--system-site-packages for upgrade --install
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1344
changelog.d/(if the patch affects the end users)Summary of changes
The
--system-site-packageoption currently doesn't do anything when used withupgrade --install.This PR adds
venv_argsto the upgrade command so that it can be passed through to the install command, when the--installoption is set.Test plan
Tested by running
Before the PR this returns:
After applying the PR it returns:
Also successfully tested by installing https://github.com/essembeh/gnome-extensions-cli which requires the system site packages to work for the
--dbusintegration. Before this ran into an error because of the missing requiredsystem dependencies.