Skip to content

Add quotes to title and fix tag name in release action #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dukecat0 merged 5 commits into from
Jun 3, 2024
Merged

Add quotes to title and fix tag name in release action #1437

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fae103c
Add quotes to the title in release action
dukecat0 Jun 2, 2024
6ecde34
Fix tag_name for upload_zipapp action
dukecat0 Jun 2, 2024
9498b7b
Update release.yml
dukecat0 Jun 2, 2024
d92afd4
Generate zipapp directly before uploading to release
dukecat0 Jun 3, 2024
f92ae1c
Update .github/workflows/release.yml
dukecat0 Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
if [ "${{ github.event_name }}" == "workflow_dispatch" ]; then
echo "version=${{ github.event.inputs.version }}" >> "$GITHUB_OUTPUT"
else
TITLE=${{ github.event.pull_request.title }}
TITLE="${{ github.event.pull_request.title }}"
echo "version=${TITLE/: [[:alnum:]]*}" >> "$GITHUB_OUTPUT"
fi
- name: Bump version and push tag
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
cache: "pip"
- name: Install nox
run: pip install nox
- name: Build sdist and wheel
- name: Build sdist and wheel
run: nox --error-on-missing-interpreters --non-interactive --session build
- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@v1.8.14
Expand All @@ -89,19 +89,26 @@ jobs:

upload-zipapp:
name: Upload zipapp to GitHub Release
needs: create-release
needs: [create-release, create-tag]
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- uses: dawidd6/action-download-artifact@v3
- name: Checkout ${{ needs.create-tag.outputs.release-tag }}
uses: actions/checkout@v4
with:
ref: "${{ needs.create-tag.outputs.release-tag }}"
- name: Set up Python ${{ env.default-python }}
uses: actions/setup-python@v5
with:
name: pipx.pyz
workflow: tests.yml
workflow_conclusion: success
pr: ${{ github.event.pull_request.number }}
python-version: ${{ env.default-python }}
cache: "pip"
- name: Install nox
run: pip install nox
- name: Build zipapp
run: nox --error-on-missing-interpreters --non-interactive --session zipapp
- name: Upload to release
uses: softprops/action-gh-release@v2
with:
files: pipx.pyz
tag_name: "${{ needs.create-release.outputs.release-tag }}"
tag_name: "${{ needs.create-tag.outputs.release-tag }}"