Add Python version specifiers to [core] dependencies#4492
Merged
Conversation
Add Python version specifiers to importlib_metadata, importlib_resources and tomli dependencies, to require them only on Python versions on which they are actually used.
Member
|
Unfortunately, applying this change will almost certainly break the update routine for the vendored packages due to pip not respecting environment markers. If we add these exclusions, we'll also at the very least need to add them to the workaround in that routine. Or perhaps something similar to the Even better would be to find a solution to pypa/pip#12770; perhaps |
jaraco
added a commit
that referenced
this pull request
Jul 21, 2024
More durable workaround for pypa/pip#12770. Ref #4492.
Member
|
In 022cedb, I switched to uv for vendoring and it works great, so no longer have any concerns about the markers. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add Python version specifiers to importlib_metadata, importlib_resources and tomli dependencies, to require them only on Python versions on which they are actually used.
Pull Request Checklist
newsfragments/.(See documentation for details)