[WIP] ci: tox/Travis: use pexpect for dep only #5313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5313 +/- ##
===========================================
- Coverage 90.48% 75.53% -14.96%
===========================================
Files 115 115
Lines 26258 26273 +15
Branches 2587 2586 -1
===========================================
- Hits 23760 19845 -3915
- Misses 2159 5917 +3758
- Partials 339 511 +172
Continue to review full report at Codecov.
|
For pytest-dev#5306 I would have to add `testing/test_pytester.py` to the default pos args, but that would run all other tests therein additionally. This also adds pexpect tests to the MacOS job, which appears to have caused trouble at least in the past, and likely needs fixing here before this works.
Contributor
|
@blueyed What are you looking for in my review? There's a whole chain of tickets leading to this one, enough that it'll take me awhile to try to understand what's going on here. Can you direct me to how I can help? |
Contributor
Author
|
@jaraco |
Contributor
Author
Contributor
Author
blueyed
changed the title
Contributor
Author
|
Moved into / closing in favor of #5336. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5306 I would have to add
testing/test_pytester.pyto the default pos args, but that would runall other tests therein additionally.
This also adds pexpect tests to the MacOS job, which appears to have
caused trouble at least in the past, and likely needs fixing here before
this works.
TODO: