Use `ast` instead of `eval` for string extraction #915

akx · 2022-10-31T11:14:25Z

This is safer (as we don't actually execute anything), and allows us to parse f-strings too.

Closes #769 (supersedes it)
Refs #715 (doesn't add an error yet, but doesn't crash on f-strings)

codecov · 2022-10-31T11:16:30Z

Codecov Report

Merging #915 (147946b) into master (05df10f) will decrease coverage by 0.03%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
- Coverage   91.63%   91.60%   -0.04%     
==========================================
  Files          21       21              
  Lines        4198     4217      +19     
==========================================
+ Hits         3847     3863      +16     
- Misses        351      354       +3

Impacted Files	Coverage Δ
babel/messages/extract.py	`94.75% <93.75%> (-0.12%)`	⬇️
babel/dates.py	`92.40% <0.00%> (-0.22%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

akx · 2022-10-31T15:29:54Z

Hey @DenverCoder1, now that I know you're at your keyboard 😁, mind reviewing this in kind?

babel/messages/extract.py

This is safer (as we don't actually execute anything), and allows us to parse f-strings too. Closes #769 (supersedes it) Refs #715 (doesn't add an error yet, but doesn't crash on f-strings)

magdapoppins

Looks reasonable!

akx · 2022-11-01T08:48:26Z

I've requested a couple of extra reviews off-GitHub from colleagues and such, and I suppose this is good to go :)

We'll get limited f-string support and less eval.

On Jammy, babel does *not* cope well with f-strings as values inside `_()` calls: it uses `eval` to try and figure them out, which attempts to execute the f-string, which fails because the evaluation context is empty. This is likely fixed from Babel 2.11 onwards (python-babel/babel#915) but Jammy uses babel 2.8[^1]. https://runbot.odoo.com/odoo/runbot.build.error/97849 [^1]: This doesn't seem to trigger on Noble even though it uses 2.10, but locally it does trigger on 2.10.3 (installed via pip), so ubuntu might have backported the fix or something.

On Jammy, babel does *not* cope well with f-strings as values inside `_()` calls: it uses `eval` to try and figure them out, which attempts to execute the f-string, which fails because the evaluation context is empty. This is likely fixed from Babel 2.11 onwards (python-babel/babel#915) but Jammy uses babel 2.8[^1]. https://runbot.odoo.com/odoo/runbot.build.error/97849 [^1]: This doesn't seem to trigger on Noble even though it uses 2.10, but locally it does trigger on 2.10.3 (installed via pip), so ubuntu might have backported the fix or something. closes #218803 Signed-off-by: Xavier Morel (xmo) <[email protected]>

On Jammy, babel does *not* cope well with f-strings as values inside `_()` calls: it uses `eval` to try and figure them out, which attempts to execute the f-string, which fails because the evaluation context is empty. This is likely fixed from Babel 2.11 onwards (python-babel/babel#915) but Jammy uses babel 2.8[^1]. https://runbot.odoo.com/odoo/runbot.build.error/97849 [^1]: This doesn't seem to trigger on Noble even though it uses 2.10, but locally it does trigger on 2.10.3 (installed via pip), so ubuntu might have backported the fix or something. X-original-commit: 11145d9

On Jammy, babel does *not* cope well with f-strings as values inside `_()` calls: it uses `eval` to try and figure them out, which attempts to execute the f-string, which fails because the evaluation context is empty. This is likely fixed from Babel 2.11 onwards (python-babel/babel#915) but Jammy uses babel 2.8[^1]. https://runbot.odoo.com/odoo/runbot.build.error/97849 [^1]: This doesn't seem to trigger on Noble even though it uses 2.10, but locally it does trigger on 2.10.3 (installed via pip), so ubuntu might have backported the fix or something. closes #218887 X-original-commit: 11145d9 Signed-off-by: Xavier Morel (xmo) <[email protected]>

On Jammy, babel does *not* cope well with f-strings as values inside `_()` calls: it uses `eval` to try and figure them out, which attempts to execute the f-string, which fails because the evaluation context is empty. This is likely fixed from Babel 2.11 onwards (python-babel/babel#915) but Jammy uses babel 2.8[^1]. https://runbot.odoo.com/odoo/runbot.build.error/97849 [^1]: This doesn't seem to trigger on Noble even though it uses 2.10, but locally it does trigger on 2.10.3 (installed via pip), so ubuntu might have backported the fix or something. X-original-commit: 51c169a

On Jammy, babel does *not* cope well with f-strings as values inside `_()` calls: it uses `eval` to try and figure them out, which attempts to execute the f-string, which fails because the evaluation context is empty. This is likely fixed from Babel 2.11 onwards (python-babel/babel#915) but Jammy uses babel 2.8[^1]. https://runbot.odoo.com/odoo/runbot.build.error/97849 [^1]: This doesn't seem to trigger on Noble even though it uses 2.10, but locally it does trigger on 2.10.3 (installed via pip), so ubuntu might have backported the fix or something. closes #219024 X-original-commit: 51c169a Signed-off-by: Xavier Morel (xmo) <[email protected]>

On Jammy, babel does *not* cope well with f-strings as values inside `_()` calls: it uses `eval` to try and figure them out, which attempts to execute the f-string, which fails because the evaluation context is empty. This is likely fixed from Babel 2.11 onwards (python-babel/babel#915) but Jammy uses babel 2.8[^1]. https://runbot.odoo.com/odoo/runbot.build.error/97849 [^1]: This doesn't seem to trigger on Noble even though it uses 2.10, but locally it does trigger on 2.10.3 (installed via pip), so ubuntu might have backported the fix or something. closes #219074 X-original-commit: 51c169a Signed-off-by: Xavier Morel (xmo) <[email protected]>

On Jammy, babel does *not* cope well with f-strings as values inside `_()` calls: it uses `eval` to try and figure them out, which attempts to execute the f-string, which fails because the evaluation context is empty. This is likely fixed from Babel 2.11 onwards (python-babel/babel#915) but Jammy uses babel 2.8[^1]. https://runbot.odoo.com/odoo/runbot.build.error/97849 [^1]: This doesn't seem to trigger on Noble even though it uses 2.10, but locally it does trigger on 2.10.3 (installed via pip), so ubuntu might have backported the fix or something. closes #219048 X-original-commit: 51c169a Signed-off-by: Xavier Morel (xmo) <[email protected]>

On Jammy, babel does *not* cope well with f-strings as values inside `_()` calls: it uses `eval` to try and figure them out, which attempts to execute the f-string, which fails because the evaluation context is empty. This is likely fixed from Babel 2.11 onwards (python-babel/babel#915) but Jammy uses babel 2.8[^1]. https://runbot.odoo.com/odoo/runbot.build.error/97849 [^1]: This doesn't seem to trigger on Noble even though it uses 2.10, but locally it does trigger on 2.10.3 (installed via pip), so ubuntu might have backported the fix or something. closes #219090 X-original-commit: 51c169a Signed-off-by: Xavier Morel (xmo) <[email protected]>

On Jammy, babel does *not* cope well with f-strings as values inside `_()` calls: it uses `eval` to try and figure them out, which attempts to execute the f-string, which fails because the evaluation context is empty. This is likely fixed from Babel 2.11 onwards (python-babel/babel#915) but Jammy uses babel 2.8[^1]. https://runbot.odoo.com/odoo/runbot.build.error/97849 [^1]: This doesn't seem to trigger on Noble even though it uses 2.10, but locally it does trigger on 2.10.3 (installed via pip), so ubuntu might have backported the fix or something. closes odoo#218803 Signed-off-by: Xavier Morel (xmo) <[email protected]>

akx added bug enhancement area/messages labels Oct 31, 2022

akx added this to the Babel 2.11 milestone Oct 31, 2022

akx force-pushed the f-strings branch 3 times, most recently from f324539 to 5eda164 Compare October 31, 2022 11:33

akx marked this pull request as ready for review October 31, 2022 12:18

akx force-pushed the f-strings branch from 5eda164 to 4dfd49f Compare October 31, 2022 12:53

DenverCoder1 reviewed Oct 31, 2022

View reviewed changes

babel/messages/extract.py Outdated Show resolved Hide resolved

akx force-pushed the f-strings branch from 4dfd49f to 395d37d Compare October 31, 2022 17:23

Use ast instead of eval for string extraction

147946b

This is safer (as we don't actually execute anything), and allows us to parse f-strings too. Closes #769 (supersedes it) Refs #715 (doesn't add an error yet, but doesn't crash on f-strings)

akx force-pushed the f-strings branch from 395d37d to 147946b Compare October 31, 2022 18:17

magdapoppins approved these changes Nov 1, 2022

View reviewed changes

akx merged commit 2e5708f into master Nov 1, 2022

akx deleted the f-strings branch November 1, 2022 08:48

xmo-odoo mentioned this pull request Jul 14, 2025

[FIX] *: f-strings inside _() calls odoo/odoo#218803

Closed

fw-bot mentioned this pull request Jul 14, 2025

[FIX] *: f-strings inside _() calls odoo/odoo#218887

Closed

fw-bot mentioned this pull request Jul 15, 2025

[FIX] *: f-strings inside _() calls odoo/odoo#219024

Closed

fw-bot mentioned this pull request Jul 15, 2025

[FIX] *: f-strings inside _() calls odoo/odoo#219048

Closed

fw-bot mentioned this pull request Jul 15, 2025

[FIX] *: f-strings inside _() calls odoo/odoo#219074

Closed

fw-bot mentioned this pull request Jul 15, 2025

[FIX] *: f-strings inside _() calls odoo/odoo#219090

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use `ast` instead of `eval` for string extraction #915

Use `ast` instead of `eval` for string extraction #915

Uh oh!

akx commented Oct 31, 2022

Uh oh!

codecov bot commented Oct 31, 2022 •

edited

Loading

Uh oh!

akx commented Oct 31, 2022

Uh oh!

Uh oh!

magdapoppins left a comment

Uh oh!

akx commented Nov 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Use ast instead of eval for string extraction #915

Use ast instead of eval for string extraction #915

Uh oh!

Conversation

akx commented Oct 31, 2022

Uh oh!

codecov bot commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

akx commented Oct 31, 2022

Uh oh!

Uh oh!

magdapoppins left a comment

Choose a reason for hiding this comment

Uh oh!

akx commented Nov 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Use `ast` instead of `eval` for string extraction #915

Use `ast` instead of `eval` for string extraction #915

codecov bot commented Oct 31, 2022 •

edited

Loading