Migrate to MarkupContent and convert docstrings to Markdown#80
Conversation
|
I am also happy to transfer https://github.com/krassowski/docstring-to-markdown to python-lsp organization if you agree (I will obviously continue to maintain it and address any issues). |
Sounds good to me. |
|
It has been a while since this has been touched, is there any plans to release these changes? |
|
To celebrate one year anniversary of this pull request I resolved the merge conflicts 🎉. And all checks are still passing 💚. |
ccordoba12
left a comment
There was a problem hiding this comment.
This looks pretty good to me, thanks @krassowski!
ccordoba12
left a comment
There was a problem hiding this comment.
@krassowski, last comments for you then this should be ready.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks @krassowski!
Migrate from deprecated
MarkedStringtoMarkupContent(fixes #21) and convert documentation strings to Markdown usingdocstring_to_markdownfixes #22, and supersedes #36.Clients can now choose whether they prefer to receive
plaintextormarkdownmarkup by specifying:HoverClientCapabilities.contentFormatfor hover,SignatureHelpClientCapabilities.documentationFormatfor signature, orCompletionClientCapabilities.completionItem.documentationFormatfor completionsand the client preference will be respected.