Make _parse_size robust to already parsed values #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(needed for unpickling a folium Map)
for more information, see https://pre-commit.ci
Conengmo
requested changes
Oct 13, 2023
Member
Conengmo
left a comment
Conengmo
left a comment
There was a problem hiding this comment.
Nice to have. If people want to put in sizes in the output format, why not let them.
Could you add some test cases to test_parse_size and test_parse_size_exceptions though?
Contributor
Author
|
Good to go ! |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor change is NOT needed if we want to be able to unpickle a folium Map afterwards, it is only there for code robustness.