-
Notifications
You must be signed in to change notification settings - Fork 69
Add type hints #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add type hints #146
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f9a1557
Update colormap.py
Conengmo 891642f
Create test_mypy.yml
Conengmo 8f5aa00
add Mypy requirement
Conengmo 7525a9f
Update pyproject.toml
Conengmo 3aa41f6
Update element.py
Conengmo 8f02e42
utilities.py wip
Conengmo 5b009bd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b3cc3ee
Update branca/utilities.py
Conengmo 5834665
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a7e7045
Restore Div and MacroElement
Conengmo 6faee42
Update test_mypy.yml
Conengmo 59500f8
Update colormap.py
Conengmo 9323d12
Update element.py
Conengmo ef91cd9
Update utilities.py
Conengmo 00f9a0e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d59cee9
error after rebase
Conengmo e21b6d4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 810a860
Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"
Conengmo 26f7a37
another rebase artefact :/
Conengmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: Mypy type hint checks | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| run: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Micromamba env | ||
| uses: mamba-org/setup-micromamba@v1 | ||
| with: | ||
| environment-name: TEST | ||
| create-args: >- | ||
| python=3 | ||
| --file requirements.txt | ||
| --file requirements-dev.txt | ||
| - name: Install branca from source | ||
| shell: bash -l {0} | ||
| run: | | ||
| python -m pip install -e . --no-deps --force-reinstall | ||
| - name: Mypy test | ||
| shell: bash -l {0} | ||
| run: | | ||
| mypy branca | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha! You are always one (many actually) step ahead of me.