gh-67693: Fix urlunparse() and urlunsplit() for URIs with path starting with multiple slashes and no authority #113563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple slashes and no authority.
serhiy-storchaka
added
needs backport to 3.11
serhiy-storchaka
changed the title
serhiy-storchaka
added
needs backport to 3.8
needs backport to 3.10
Member
Author
|
It fixes also more serious security issue #67693. |
serhiy-storchaka
force-pushed
the
urls2
branch
from
b54b670 to
26951a7
Compare
vadmium
reviewed
May 12, 2024
Member
vadmium
left a comment
vadmium
left a comment
There was a problem hiding this comment.
The code changes and tests look good to me.
| ('//path/to/file', | ||
| ('', 'path', '/to/file', '', '', ''), | ||
| ('', 'path', '/to/file', '', '')), | ||
| ('////path/to/file', |
Member
Author
There was a problem hiding this comment.
This case was broken.
| ('scheme://path/to/file', | ||
| ('scheme', 'path', '/to/file', '', '', ''), | ||
| ('scheme', 'path', '/to/file', '', '')), | ||
| ('scheme:////path/to/file', |
Member
Author
There was a problem hiding this comment.
This case was broken.
| ('file:///tmp/junk.txt', | ||
| ('file', '', '/tmp/junk.txt', '', '', ''), | ||
| ('file', '', '/tmp/junk.txt', '', '')), | ||
| ('file:////tmp/junk.txt', |
Member
Author
There was a problem hiding this comment.
This case was broken.
| ('file:////tmp/junk.txt', | ||
| ('file', '', '//tmp/junk.txt', '', '', ''), | ||
| ('file', '', '//tmp/junk.txt', '', '')), | ||
| ('file://///tmp/junk.txt', |
Member
Author
There was a problem hiding this comment.
This case was broken.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13. |
|
GH-119025 is a backport of this pull request to the 3.11 branch. |
|
GH-119026 is a backport of this pull request to the 3.10 branch. |
|
GH-119027 is a backport of this pull request to the 3.9 branch. |
|
GH-119028 is a backport of this pull request to the 3.8 branch. |
This was referenced Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15297.
Co-authored-by: Ashwin Ramaswami [email protected]