GH-77189: Prevent backslash stripping in urllib parse_http_list #142692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
I will certainly agree that this shouldn't be backported. People (Libraries and Frameworks) have a dependency on these bugs, since they are present as behaviors for a long time. We will how severe this is, what benefits does fixing it bring. |
Member
Author
|
Yep - I'm going to leave this one open for a bit and see if anyone else has opinions on the fixing it. If not, then I think we should just close the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More spelunking...This has been a bug for a very long time. While one could argue it's not problematic since no one has complained since, the output is fundamentally malformed without the escape. This is also an undocumented but changing urllib scares me so I don't think this should be backported.