Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jan 12, 2026

I expect it to fail till #143718 is merged.

I had to refactor copy_strip to a separate file to avoid having to build Python.


📚 Documentation preview 📚: https://cpython-previews--143742.org.readthedocs.build/

🏃 Run preview 🏃: https://github.com/python/cpython/actions/runs/20930506392/job/60140508484?pr=143742

@StanFromIreland
Copy link
Member Author

A downside of how I currently have it is that it need the entire docs job to finish (i.e. it includes waiting for the doc tests), we could have it run earlier by moving it under the docs job (though I don't think that is particularly nice), however since it runs in 7 seconds I think it is a negligible issue.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Jan 12, 2026

@webknjaz could you please take a peek at this?

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this new job also be required by "All required checks pass"?

image

https://github.com/python/cpython/actions/runs/20930506392?pr=143742


A downside of how I currently have it is that it need the entire docs job to finish (i.e. it includes waiting for the doc tests), we could have it run earlier by moving it under the docs job (though I don't think that is particularly nice), however since it runs in 7 seconds I think it is a negligible issue.

The time isn't a problem, but there's quite a bit of extra complexity and config to achieve this, when it could be ~10 extra lines to add a couple of steps to the existing docs job.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this stay in Lib/idlelib/help.py?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would have to build CPython if we want to be able to modify it, that's not particularly fast?

hugovk

This comment was marked as duplicate.

@StanFromIreland
Copy link
Member Author

Should this new job also be required by "All required checks pass"?

Terry asked me to not make it required on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants