gh-144648: Improve libproc usage in _remote_debugging #144649
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a missing include and use proc_listpids rather than proc_listallpids, since it is functionally identical and more widely implemented.
Contributor
|
Since this change allow to use functionality on more OSes I believe we should add a NEWS entry. |
pablogsal
approved these changes
Feb 10, 2026
Member
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the improvement !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a missing include and use
proc_listpidsrather thanproc_listallpids, since it is functionally identical and more widely implemented.