Skip to content

Conversation

@DenverCoder1
Copy link
Contributor

@DenverCoder1 DenverCoder1 commented Nov 4, 2022

@github-actions

This comment has been minimized.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks (and welcome to typeshed)! I'm not too familiar with babel, but here's two suggestions from quickly skimming the source code:

@AlexWaygood
Copy link
Member

Btw, we have pre-commit.ci's "autofix" feature enabled for this repo. It looks like you didn't tick the "allow maintainers to edit this PR" box when you filed this PR — I don't think there's any way for you to change it now, but if you had ticked that box, some bots would have already automatically fixed the black/isort formatting issues for you. Something to bear in mind for future PRs :)

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DenverCoder1
Copy link
Contributor Author

DenverCoder1 commented Nov 4, 2022

Btw, we have pre-commit.ci's "autofix" feature enabled for this repo. It looks like you didn't tick the "allow maintainers to edit this PR" box when you filed this PR — I don't think there's any way for you to change it now, but if you had ticked that box, some bots would have already automatically fixed the black/isort formatting issues for you. Something to bear in mind for future PRs :)

I'm aware of the issue and unfortunately I don't have the option to "allow maintainers to edit this PR" since I created the fork in an Organization account.

I was having a hard time getting pre-commit to run locally and it turns out the language_version: python3.9 in the .pre-commit-config.yaml was what was causing it to fail with RuntimeError: failed to find interpreter for Builtin discover of python_spec='python3.9'. I resolved that now by removing it locally. (I was also able to get it to run by installing python3.9.)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 26841a8 into python:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support types for format_compact_decimal (Babel 2.11.0)

2 participants