feat: Improve logging throughout the Dynamo path by gs-olive · Pull Request #2405 · pytorch/TensorRT

gs-olive · 2023-10-20T17:22:29Z

Description

Add clear logging at the beginning and end of each phase of compilation
Reword logging in certain locations for clarity

Addresses #2399

Type of change

Documentation and logging improvement

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ x ] I have added tests to verify my fix or my feature
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

py/torch_tensorrt/dynamo/utils.py

py/torch_tensorrt/dynamo/compile.py

peri044

LGTM

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/dynamo/_compiler.py

py/torch_tensorrt/dynamo/conversion/_TRTInterpreter.py

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/dynamo/utils.py

py/torch_tensorrt/dynamo/lowering/passes/_aten_lowering_pass.py

gs-olive · 2024-06-14T02:37:12Z

Sample logs:

DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Converting node mean (kind: aten.mean.dim, args: ('[RELU]-[aten_ops.relu.default]-[relu_16]_output <tensorrt.ITensor [shape=(8, 512, 7, 7), dtype=DataType.HALF]>', [-1, -2], True))
DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Ran node mean with properties: Inputs: (relu_16: (8, 512, 7, 7)@torch.float16, [-1, -2], True) | Outputs: (mean: (8, 512, 1, 1)@torch.float16)
DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Running node reshape_default, a call_function node with target aten.reshape.default in the TensorRT Interpreter
DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Converting node reshape_default (kind: aten.reshape.default, args: ('[REDUCE]-[aten_ops.mean.dim]-[mean]_output <tensorrt.ITensor [shape=(8, 512, 1, 1), dtype=DataType.HALF]>', [8, 512]))
DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Ran node reshape_default with properties: Inputs: (mean: (8, 512, 1, 1)@torch.float16, [8, 512]) | Outputs: (reshape_default: (8, 512)@torch.float16)
DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Running node _param_constant61, a get_attr node with target _param_constant61 in the TensorRT Interpreter
DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Ran node _param_constant61 with properties: Inputs: () | Outputs: (_param_constant61: (1000,)@float16)
DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Running node _frozen_param0, a get_attr node with target _frozen_param0 in the TensorRT Interpreter
DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Ran node _frozen_param0 with properties: Inputs: () | Outputs: (_frozen_param0: (512, 1000)@float16)
DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Running node addmm, a call_function node with target aten.addmm.default in the TensorRT Interpreter
DEBUG:torch_tensorrt.dynamo.conversion._TRTInterpreter:Converting node addmm (kind: aten.addmm.default, args: ('<torch.Tensor as np.ndarray [shape=(1000,), dtype=float16]>', '[SHUFFLE]-[aten_ops.reshape.default]-[reshape_default]_output <tensorrt.ITensor [shape=(8, 512), dtype=DataType.HALF]>', '<torch.Tensor as np.ndarray [shape=(512, 1000), dtype=float16]>'))

py/torch_tensorrt/dynamo/conversion/converter_utils.py

peri044

LGTM

- Add clear logging at the beginning and end of each phase of compilation - Reword logging in certain locations for clarity

gs-olive requested a review from narendasan October 20, 2023 17:22

gs-olive self-assigned this Oct 20, 2023

facebook-github-bot added the cla signed label Oct 20, 2023

github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Oct 20, 2023

github-actions bot requested a review from apbose October 20, 2023 17:22

github-actions bot approved these changes Oct 20, 2023

View reviewed changes

peri044 requested changes Oct 23, 2023

View reviewed changes

py/torch_tensorrt/dynamo/utils.py Outdated Show resolved Hide resolved

py/torch_tensorrt/dynamo/compile.py Outdated Show resolved Hide resolved

peri044 approved these changes Oct 23, 2023

View reviewed changes

gs-olive force-pushed the improve_logging branch from 8df34b8 to 56a970f Compare November 7, 2023 18:14

github-actions bot approved these changes Nov 7, 2023

View reviewed changes

gs-olive force-pushed the improve_logging branch from 56a970f to e5eec9d Compare December 7, 2023 20:48

github-actions bot approved these changes Dec 7, 2023

View reviewed changes

narendasan reviewed Dec 18, 2023

View reviewed changes

py/torch_tensorrt/dynamo/_compiler.py Outdated Show resolved Hide resolved

py/torch_tensorrt/dynamo/_compiler.py Outdated Show resolved Hide resolved

py/torch_tensorrt/dynamo/conversion/_TRTInterpreter.py Show resolved Hide resolved

github-actions bot added the component: lowering Issues re: The lowering / preprocessing passes label Dec 27, 2023

gs-olive force-pushed the improve_logging branch from b3d7fb4 to 93d16a6 Compare December 27, 2023 17:21

github-actions bot approved these changes Dec 27, 2023

View reviewed changes

peri044 reviewed Jan 10, 2024

View reviewed changes

py/torch_tensorrt/dynamo/utils.py Outdated Show resolved Hide resolved

py/torch_tensorrt/dynamo/lowering/passes/_aten_lowering_pass.py Outdated Show resolved Hide resolved

narendasan added the Blocked Issue cannot be resolved until a change in a dependency label Feb 6, 2024

github-actions bot requested a review from peri044 February 6, 2024 22:30

gs-olive force-pushed the improve_logging branch from 93d16a6 to 45eeaa8 Compare February 27, 2024 18:37

github-actions bot removed the component: lowering Issues re: The lowering / preprocessing passes label Feb 27, 2024

narendasan removed the Blocked Issue cannot be resolved until a change in a dependency label Apr 12, 2024

gs-olive force-pushed the improve_logging branch from 029759e to 307eede Compare June 14, 2024 01:37

github-actions bot added component: lowering Issues re: The lowering / preprocessing passes and removed component: lowering Issues re: The lowering / preprocessing passes labels Jun 14, 2024

gs-olive requested a review from narendasan June 14, 2024 01:40

peri044 requested changes Jun 14, 2024

View reviewed changes

py/torch_tensorrt/dynamo/conversion/converter_utils.py Outdated Show resolved Hide resolved

py/torch_tensorrt/dynamo/conversion/converter_utils.py Outdated Show resolved Hide resolved

github-actions bot added the component: lowering Issues re: The lowering / preprocessing passes label Jun 14, 2024

gs-olive force-pushed the improve_logging branch from 3a61a9b to c6df4be Compare June 14, 2024 18:29

gs-olive requested a review from peri044 June 14, 2024 18:29

peri044 approved these changes Jun 14, 2024

View reviewed changes

gs-olive force-pushed the improve_logging branch 2 times, most recently from d3bc824 to a0d4807 Compare June 14, 2024 23:14

gs-olive added 5 commits June 17, 2024 12:06

feat: Improve logging throughout the Dynamo path

1d102b7

- Add clear logging at the beginning and end of each phase of compilation - Reword logging in certain locations for clarity

fix: Add I/O values for nodes

3609326

Remove ShapeProp pass

f6f8b7d

Remove unnecessary logging

fab9832

Address review comments; add support for integer inputs

b371e63

gs-olive force-pushed the improve_logging branch from a0d4807 to b371e63 Compare June 17, 2024 19:07

gs-olive merged commit 8a350ad into main Jun 18, 2024

gs-olive deleted the improve_logging branch June 18, 2024 18:40

Conversation

gs-olive commented Oct 20, 2023

Description

Type of change

Checklist:

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

peri044 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gs-olive commented Jun 14, 2024

Uh oh!

Uh oh!

Uh oh!

peri044 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants