Skip to content

fix: convert_module_to_trt_engine#2728

Merged
zewenli98 merged 2 commits intopytorch:mainfrom
zewenli98:fix_convert_module_to_trt_engine
Apr 25, 2024
Merged

fix: convert_module_to_trt_engine#2728
zewenli98 merged 2 commits intopytorch:mainfrom
zewenli98:fix_convert_module_to_trt_engine

Conversation

@zewenli98
Copy link
Collaborator

@zewenli98 zewenli98 commented Apr 5, 2024

Description

fix: convert_module_to_trt_engine
add doc.

Fixes #2692

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 added the bug Something isn't working label Apr 5, 2024
@zewenli98 zewenli98 requested review from narendasan and peri044 April 5, 2024 00:25
@zewenli98 zewenli98 self-assigned this Apr 5, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation component: tests Issues re: Tests component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Apr 5, 2024
@github-actions github-actions bot requested a review from gs-olive April 5, 2024 00:25
peri044
peri044 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

narendasan
narendasan reviewed Apr 17, 2024
View reviewed changes
@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: build system Issues re: Build system component: runtime labels Apr 18, 2024
@zewenli98 zewenli98 force-pushed the fix_convert_module_to_trt_engine branch from 3ad29da to c8ffcde Compare April 18, 2024 22:22
@github-actions github-actions bot removed component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: build system Issues re: Build system component: runtime labels Apr 18, 2024
@zewenli98 zewenli98 force-pushed the fix_convert_module_to_trt_engine branch from c8ffcde to c36fed1 Compare April 18, 2024 22:29
@zewenli98 zewenli98 requested a review from narendasan April 18, 2024 22:38
@zewenli98 zewenli98 merged commit ad0d786 into pytorch:main Apr 25, 2024
peri044 pushed a commit that referenced this pull request Apr 26, 2024
@zewenli98 @peri044
fix: convert_module_to_trt_engine (#2728)
08f1636
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@zewenli98 @laikhtewari
fix: convert_module_to_trt_engine (#2728)
15c57df
@zewenli98 zewenli98 deleted the fix_convert_module_to_trt_engine branch January 12, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peri044 peri044 peri044 approved these changes

@gs-olive gs-olive Awaiting requested review from gs-olive

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@zewenli98 zewenli98

Labels

bug Something isn't working cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

✨[Bug] Add lowering, decompositions, nn.Module support for convert_module_to_trt_engine API

4 participants

@zewenli98 @narendasan @peri044 @facebook-github-bot