Conversation
41f0324 to
1360961
Compare
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/lowering/test_decompositions.py 2024-06-06 22:53:37.987181+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/lowering/test_decompositions.py 2024-06-06 22:55:54.420669+00:00
@@ -869,29 +869,29 @@
DECIMALS_OF_AGREEMENT,
f"Select_scatter TRT outputs don't match with the original model.",
)
empty_ops = [
- (
- "empty_stride_one_dimension_firstcase",
- [5, 5],
- [1, 2],
- None,
- ),
- (
- "empty_stride_two_dimension_secondcase",
- [5, 5],
- [2, 2],
- None,
- ),
- (
- "empty_three_dimension",
- [8, 8, 8],
- [1, 2, 3],
- torch.int32,
- ),
- ]
+ (
+ "empty_stride_one_dimension_firstcase",
+ [5, 5],
+ [1, 2],
+ None,
+ ),
+ (
+ "empty_stride_two_dimension_secondcase",
+ [5, 5],
+ [2, 2],
+ None,
+ ),
+ (
+ "empty_three_dimension",
+ [8, 8, 8],
+ [1, 2, 3],
+ torch.int32,
+ ),
+ ]
@parameterized.expand(
[(empty_op[0], empty_op[1], empty_op[2], empty_op[3]) for empty_op in empty_ops]
)
def test_empty_stride(self, _, shape_or_input, stride, data_type):
zewenli98
approved these changes
Jun 10, 2024
Collaborator
zewenli98
left a comment
There was a problem hiding this comment.
Overall LGTM, just need a minor fix
| import torch_tensorrt | ||
| from parameterized import parameterized | ||
| from torch.testing._internal.common_utils import TestCase, run_tests | ||
| from parameterized import parameterized |
1360961 to
aeae9b3
Compare
ec15e77 to
e296688
Compare
adding test cases and correcting empty__stride decomposition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: