Skip to content

add dynamic shape support for aten.ops.gt and aten.ops.ge#2883

Merged
lanluo-nvidia merged 2 commits intomainfrom
lluo/dynamic_shape_ge_gt
Jun 7, 2024
Merged

add dynamic shape support for aten.ops.gt and aten.ops.ge#2883
lanluo-nvidia merged 2 commits intomainfrom
lluo/dynamic_shape_ge_gt

Conversation

@lanluo-nvidia
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia commented Jun 4, 2024

Description

Add dynamic shape support to aten ops gt/ge

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia requested review from keehyuna and peri044 June 4, 2024 03:24
@github-actions github-actions bot added the component: tests Issues re: Tests label Jun 4, 2024
@github-actions github-actions bot requested a review from narendasan June 4, 2024 03:24
peri044
peri044 requested changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testcases LGTM. Please add supports_dynamic_shapes=True in aten_ops_converters.py for both of these converters.

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 4, 2024
@lanluo-nvidia lanluo-nvidia requested a review from peri044 June 4, 2024 21:45
peri044
peri044 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanluo-nvidia lanluo-nvidia merged commit 050272f into main Jun 7, 2024
peri044 pushed a commit that referenced this pull request Jun 12, 2024
@lanluo-nvidia @peri044
add dynamic shape support for aten.ops.gt and aten.ops.ge (#2883)
c6d1645
@lanluo-nvidia lanluo-nvidia deleted the lluo/dynamic_shape_ge_gt branch January 9, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peri044 peri044 peri044 approved these changes

@keehyuna keehyuna Awaiting requested review from keehyuna

@narendasan narendasan Awaiting requested review from narendasan

Assignees

No one assigned

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lanluo-nvidia @peri044 @facebook-github-bot