Skip to content

add dynamic shape support for sin/cos/cat#2887

Merged
peri044 merged 4 commits intomainfrom
lluo/dynamic_shapes_sin_cos
Jun 10, 2024
Merged

add dynamic shape support for sin/cos/cat#2887
peri044 merged 4 commits intomainfrom
lluo/dynamic_shapes_sin_cos

Conversation

@lanluo-nvidia
Copy link
Collaborator

Description

Add dynamic shape support for sin/cos

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 4, 2024
@lanluo-nvidia lanluo-nvidia requested a review from peri044 June 4, 2024 23:09
@lanluo-nvidia lanluo-nvidia changed the title add dynamic shape support for sin/cos add dynamic shape support for sin/cos/cat Jun 5, 2024
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 115c372 into main Jun 10, 2024
@lanluo-nvidia lanluo-nvidia deleted the lluo/dynamic_shapes_sin_cos branch January 9, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants