-
Notifications
You must be signed in to change notification settings - Fork 794
Adding test for CadenceWithSoftmaxQuantizer #16206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16206
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated FailureAs of commit 98af640 with merge base daf93a1 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive test coverage for CadenceWithSoftmaxQuantizer and CadenceWith16BitConvActivationsQuantizer by removing them from the exclusion list and adding corresponding annotation tests. The changes ensure all A16 (16-bit activation) quantizers have proper test coverage for their annotation behavior.
Key changes:
- Removed
CadenceWithSoftmaxQuantizerandCadenceWith16BitConvActivationsQuantizerfrom the excluded quantizers list - Added three new parameterized test cases for conv1d, conv2d, and softmax operations with A16 quantization
- Implemented helper methods
_build_conv1d_graph,_build_conv2d_graph, and_build_softmax_graphfollowing the established testing pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: hsharma35 Differential Revision: D88896712
de467ff to
6c14912
Compare
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: hsharma35 Differential Revision: D88896712
6c14912 to
eaea838
Compare
Summary: Pull Request resolved: pytorch#16206 Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: hsharma35 Differential Revision: D88896712
eaea838 to
f93d13f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
f93d13f to
0947e51
Compare
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
0947e51 to
81f53ea
Compare
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
81f53ea to
6aed509
Compare
Summary: Pull Request resolved: pytorch#16206 Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
6aed509 to
cdcdae4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary: Pull Request resolved: pytorch#16206 Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
cdcdae4 to
98af640
Compare
Summary:
Add annotation tests for CadenceWithSoftmaxQuantizer.
https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369
Reviewed By: hsharma35
Differential Revision: D88896712