Skip to content

Fix Optional and Union typing hints in ignite/handlers/ema_handler.py#3590

Merged
vfdev-5 merged 2 commits intopytorch:masterfrom
ramyars466:fix/optional-hints-ema-handler
Feb 25, 2026
Merged

Fix Optional and Union typing hints in ignite/handlers/ema_handler.py#3590
vfdev-5 merged 2 commits intopytorch:masterfrom
ramyars466:fix/optional-hints-ema-handler

Conversation

@ramyars466
Copy link
Contributor

Replaces Optional[X] with X | None and Union[X, Y] with X | Y
for modern Python 3.10+ typing style.

Part of #3481

@github-actions github-actions bot added the module: handlers Core Handlers module label Feb 25, 2026
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 25, 2026

@omkar-334 thanks a lot for reviewing community PRs!
Just a small hint on the review, please ask the contributor to revert all unrelated, extra empty lines etc additions especially in the package itself (it can be fine if in the tests some extra empty line is removed)/

@omkar-334
Copy link
Contributor

@omkar-334 thanks a lot for reviewing community PRs! Just a small hint on the review, please ask the contributor to revert all unrelated, extra empty lines etc additions especially in the package itself (it can be fine if in the tests some extra empty line is removed)/

Yes, i've been looking at extra lines/comments and unrelated lines too, i didn;t tag it here because it was just one. Will take care from next time.
thanks!

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vfdev-5 vfdev-5 enabled auto-merge February 25, 2026 11:09
@vfdev-5 vfdev-5 added this pull request to the merge queue Feb 25, 2026
Merged via the queue into pytorch:master with commit ca3371f Feb 25, 2026
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: handlers Core Handlers module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants