[RL] Changes to enable compilation for trainer#2568
Open
Lucaskabela wants to merge 2 commits intopytorch:mainfrom
Open
[RL] Changes to enable compilation for trainer#2568Lucaskabela wants to merge 2 commits intopytorch:mainfrom
Lucaskabela wants to merge 2 commits intopytorch:mainfrom
Conversation
tianyu-l
reviewed
Mar 13, 2026
Contributor
There was a problem hiding this comment.
if we go with pytorch varlen, do we still need to worry about this file? cc @wwwjn
8a62589 to
be75f04
Compare
tianyu-l
reviewed
Mar 13, 2026
be75f04 to
520d314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, we enable naive, JIT style torch.compile for the RL policy trainer. This is the first step towards speeding up the trainer model. Changes are:
layer -> This is crticial, as
torch.compile()results in logit changescompile=TrainerCompileConfig(enable=True). Default backend is 'eager'
can't be traced by the compiler) into a module-level FlashAttnVarlenFunction
with a fake implementation, so AOT Autograd can trace through it with FakeTensors
Test Plan
Results in the same losses as on main - the timing is now like:
Main
Changes
So we save ~50s of runtime