[torchvision] Move video utilities to internal fb/io location (#9433) (#9433)#9451
Open
NicolasHug wants to merge 1 commit intopytorch:mainfrom
Open
[torchvision] Move video utilities to internal fb/io location (#9433) (#9433)#9451NicolasHug wants to merge 1 commit intopytorch:mainfrom
NicolasHug wants to merge 1 commit intopytorch:mainfrom
Conversation
…ch#9433) (pytorch#9433) Summary: This diff moves the torchvision.io video utilities (read_video, write_video, read_video_timestamps) from the OSS location to the internal fb/io location. Changes: - Created fb/io/video.py with the full implementation of video functions - Updated fb/io/__init__.py to export video functions and internal helpers - Updated torchvision/io/__init__.py to import video functions from fb/io - Made torchvision/io/video.py a stub that re-exports from fb/io/video.py - Removed video functions from torchvision.io.__all__ (for OSS) - The (rare) TorchVision stuff that depended on video decoding utils have been migrated to TorchCodec (that's for TV only, not for the rest of the internal users). This change ensures: - Internal users can continue using 'from torchvision.io import read_video' - Internal users importing from torchvision.io.video directly still work - No BUCK changes are required - OSS/GitHub users will no longer have access to these deprecated video APIs Eventually we'll want to migrate all these internal users to TorchCodec, but that's for later. Note: in D95081771 I bluntly removed all the torchvision decoder stuff from both GH and fbcode, but that ended up leading to tons of failed tests (that weren't triggered on the diff!). This new diff is a softer version of that. Differential Revision: D95933713 Pulled By: NicolasHug
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9451
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7d78ae8 with merge base d7400a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@NicolasHug has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95933713. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff moves the torchvision.io video utilities (read_video, write_video, read_video_timestamps) from the OSS location to the internal fb/io location.
Changes:
This change ensures:
Eventually we'll want to migrate all these internal users to TorchCodec, but that's for later.
Note: in D95081771 I bluntly removed all the torchvision decoder stuff from both GH and fbcode, but that ended up leading to tons of failed tests (that weren't triggered on the diff!). This new diff is a softer version of that.
Differential Revision: D95933713
Pulled By: NicolasHug