Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9464
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 33 PendingAs of commit 516b114 with merge base 9bf794d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
approved these changes
Apr 1, 2026
NicolasHug
approved these changes
Apr 1, 2026
|
Hey @atalman! You merged this PR, but no labels were added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the build failure in pytorch/test-infra#7865
link: https://github.com/pytorch/test-infra/actions/runs/23821498605/job/69435368907?pr=7865
The problem: CUDA 13.2 ships with CCCL (CUDA C++ Core Libraries) headers that check how MSVC's preprocessor works. MSVC has two preprocessor modes:
Traditional (default): has quirks and doesn't fully conform to the C++ standard
Standard conforming (/Zc:preprocessor): follows the C++ standard properly
CCCL's header (preprocessor.h) does a compile-time check and throws a #error if MSVC is using the traditional preprocessor, because CCCL's macros rely on standard-conforming behavior and would silently produce wrong results otherwise.
The fix: The CL environment variable is special to MSVC — it's automatically prepended to every cl.exe invocation.
cc @atalman