Skip to content

FIX: Safer close #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuillaumeFavelier merged 1 commit into from
Oct 5, 2021
Merged

FIX: Safer close #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pyvistaqt/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,16 @@ def close(self) -> None:

"""
if not self._closed:
self.app_window.close()
# Can get:
#
# RuntimeError: wrapped C/C++ object of type MainWindow has
# been deleted
#
# So let's be safe and try/except this in case of a problem.
try:
self.app_window.close()
except Exception:
pass

def _close(self) -> None:
super().close()
Expand Down