MAINT: Use setuptools_scm for versioning#356
Merged
larsoner merged 5 commits intopyvista:mainfrom Apr 6, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 96.72% 97.31% +0.59%
==========================================
Files 8 7 -1
Lines 671 671
Branches 82 82
==========================================
+ Hits 649 653 +4
+ Misses 3 0 -3
+ Partials 19 18 -1 |
Contributor
Author
|
I'll merge this and give it a try in 0.10.0. If it ends up being problematic we'll revert! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many repos I work with we've moved to
setuptools_scmfor version control. It's great because when you cut a release on GitHub with a tag like 0.10.0, that will automatically show up as the version in PyPI and sdist, but the next PR that gets merged will show up as0.11.0.dev<bunch of info>. It thus adds info and gets rid of the need to manually tick versions -- you can just cut a release on GitHub and be done.The only downside I've noticed is that downstream packages need to do
git+https://github.com/pyvista/pyvistaqtto install latestmainrather than using azipball, but this is a minor drawback and easily worked around I think.