Merged
Conversation
Contributor
Author
|
... I suggest we merge this and cut a bugfix 0.11.1 for this. I added a |
Contributor
Author
|
I also opened ipython/ipython#14463 but I don't think we should need |
Member
It is not particularly impressive and can be removed. I apologize for not leaving a clear comment. |
tkoyama010
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is a problem:
The source file for
qt_for_externalsays that it's kept for backward compat, so perhaps no surprise it doesn't work. I don't see any reason we need to triage based on being in ipython or not, though, given everything else comes fromqtpyearlier anyway.@tkoyama010 you added this in https://github.com/pyvista/pyvistaqt/pull/40/files#diff-bcab1285ff8ba2b1a25b18d87cd02a09eca4194b83196ba0c2b7939c76393d01R65, any recollection why it was necessary?