Skip to content

BUG: Fix PySide6 compatibility#586

Merged
larsoner merged 2 commits intopyvista:mainfrom
larsoner:pyside
Jun 19, 2024
Merged

BUG: Fix PySide6 compatibility#586
larsoner merged 2 commits intopyvista:mainfrom
larsoner:pyside

Conversation

@larsoner
Copy link
Contributor

So this is a problem:

$ python -c "from IPython.external.qt_for_kernel import QtGui; print(QtGui)"
<module 'PySide6.QtPrintSupport' from '/home/larsoner/python/virtualenvs/base/lib/python3.12/site-packages/PySide6/QtPrintSupport.abi3.so'>

The source file for qt_for_external says that it's kept for backward compat, so perhaps no surprise it doesn't work. I don't see any reason we need to triage based on being in ipython or not, though, given everything else comes from qtpy earlier anyway.

@tkoyama010 you added this in https://github.com/pyvista/pyvistaqt/pull/40/files#diff-bcab1285ff8ba2b1a25b18d87cd02a09eca4194b83196ba0c2b7939c76393d01R65, any recollection why it was necessary?

@larsoner
Copy link
Contributor Author

... I suggest we merge this and cut a bugfix 0.11.1 for this. I added a release.yml to remove all the dependabot PRs from the autogenerated release notes because they're unhelpful.

@larsoner
Copy link
Contributor Author

I also opened ipython/ipython#14463 but I don't think we should need IPython for this in any case

@tkoyama010
Copy link
Member

@tkoyama010 you added this in https://github.com/pyvista/pyvistaqt/pull/40/files#diff-bcab1285ff8ba2b1a25b18d87cd02a09eca4194b83196ba0c2b7939c76393d01R65, any recollection why it was necessary?

It is not particularly impressive and can be removed. I apologize for not leaving a clear comment.

@larsoner larsoner merged commit 34a85f9 into pyvista:main Jun 19, 2024
@larsoner larsoner deleted the pyside branch June 19, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants