Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 97.22% 97.31% +0.09%
==========================================
Files 8 8
Lines 648 670 +22
Branches 81 82 +1
==========================================
+ Hits 630 652 +22
Partials 18 18 |
Contributor
Author
|
Okay this is ready for review, the 3.7 Linux build correctly picks up the GC tests and they pass: Then once pyvista/pyvista#958 is in we can merge! |
Contributor
Author
|
(The windows 3.6 is just a download timeout error, I don't have permissions to restart it) |
Contributor
|
I restarted Azure but it seems like Github Actions is still not happy |
Contributor
|
BTW @pyvista/developers can we allow @larsoner to restart the CIs? |
Merged
* upstream/main: (125 commits) Bump check-jsonschema from 0.17.1 to 0.20.0 (pyvista#261) Bump pre-commit from 2.20.0 to 2.21.0 (pyvista#263) Bump matplotlib from 3.5.2 to 3.6.2 (pyvista#262) Bump isort from 5.10.1 to 5.11.4 (pyvista#264) Bump pre-commit-hooks from 4.3.0 to 4.4.0 (pyvista#260) Bump flake8 from 4.0.1 to 6.0.0 (pyvista#251) Bump actions/checkout from 2 to 3 in /.github/workflows (pyvista#246) Bump pylint from 2.13.0 to 2.15.9 (pyvista#256) Bump peter-evans/create-pull-request from 3 to 4 in /.github/workflows (pyvista#249) Bump codecov/codecov-action from 2 to 3 in /.github/workflows (pyvista#247) Bump actions/setup-python from 2 to 4 in /.github/workflows (pyvista#248) Bump numpy from 1.21.6 to 1.24.1 (pyvista#257) Bump ipython from 7.34.0 to 8.8.0 (pyvista#259) Update pre-commit hooks (pyvista#231) BUG: Safe app window close (pyvista#258) update pre-commit hooks (pyvista#228) Bump pyvista from 0.35.2 to 0.36.0 (pyvista#217) Bump imageio from 2.20.0 to 2.21.0 (pyvista#216) Bump sphinx from 5.0.2 to 5.1.1 (pyvista#213) Bump imageio from 2.19.5 to 2.20.0 (pyvista#214) ...
Contributor
Author
|
Okay finally green, ready for review/merge from my end @tkoyama010 ! |
Member
|
This is the longest I've ever seen a PR been open... and still make it to review/merge. |
akaszynski
reviewed
Jan 6, 2023
Comment on lines
+794
to
+797
| # TODO: Need to fix this allow_bad_gc: | ||
| # - the actors are not cleaned up in the non-empty scene case | ||
| # - the q_key_press leaves a lingering vtkUnsignedCharArray referred to by | ||
| # a "managedbuffer" object |
Member
There was a problem hiding this comment.
Let's open a follow-up issue for this.
akaszynski
approved these changes
Jan 6, 2023
Contributor
Author
|
Good idea @akaszynski, done in #270 so I'll merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locally this passes. Shouldn't be merged until PyVista merges pyvista/pyvista#958