Open
Conversation
d0247a1 to
0eeee5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I would like to add simple socks5 functionality. I know shadowsocks exists already but not all tools can use it. It's a long requested feature.
I am not a Go developer and I implemented this by adding a new dependency that maybe is not the preferred way considering you have implemented an ss-server to use here for shadowsocks. The dependency I added is ancient but seems stable enough and with no obvious (to me) flaws. I can change it to something else if needed. But anyways, as I implemented the feature and I am actively using it, I thought of creating a PR.
If it's going to be accepted I can create a PR for the wiki also.
Issue
#234
Assertions