Conversation
Codecov Report
@@ Coverage Diff @@
## master #1298 +/- ##
==========================================
+ Coverage 21.99% 25.33% +3.33%
==========================================
Files 695 605 -90
Lines 27847 21887 -5960
Branches 14337 11345 -2992
==========================================
- Hits 6125 5545 -580
+ Misses 16447 11224 -5223
+ Partials 5275 5118 -157
... and 381 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GaroRobe
approved these changes
Aug 3, 2022
bd65f62 to
e897e13
Compare
e897e13 to
6ae1f40
Compare
igor-egorov
approved these changes
Jan 12, 2023
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
771beb1 to
f0d746d
Compare
Harrm
approved these changes
Mar 31, 2023
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced issues
#1283
Description of the Change
Trie changes from
Core_execute_blockandCore_initialize_block+BlockBuilder_apply_extrinsic+BlockBuilder_finalize_blockare tracked separately.New tracker is created for each invocation and passed as argument.
Tracker was singleton before, so couldn't work from multiple threads.
BabeImplProposerImplBlockBuilderFactoryImplCoreImplBlockBuilderImplBlockExecutorImplCoreImplExecutorTrieStorageProviderImplTrieStorageImplBenefits
Can execute multiple blocks simultaneously.
Possible Drawbacks
Usage Examples or Tests
Alternate Designs
Replacing some interface implementations with proxy/wrappers would be convenient.