Conversation
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
xDimon
requested changes
Apr 17, 2023
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
xDimon
previously approved these changes
Apr 17, 2023
kamilsa
requested changes
Apr 18, 2023
Contributor
kamilsa
left a comment
kamilsa
left a comment
There was a problem hiding this comment.
Please add a condition in proposer that when the deadline (4 seconds from the beginning of the slot) is reached we do not add new transactions to the block
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
kamilsa
approved these changes
Apr 18, 2023
xDimon
approved these changes
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Benefits
Possible Drawbacks