Add Missing Host APIs#1811
Merged
igor-egorov merged 11 commits intomasterfrom Sep 29, 2023
Merged
Conversation
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
ecdsa_verify_prehashed Signed-off-by: Igor Egorov <igor@qdrvm.io>
Signed-off-by: Igor Egorov <igor@qdrvm.io>
Signed-off-by: Igor Egorov <igor@qdrvm.io>
Signed-off-by: Igor Egorov <igor@qdrvm.io>
turuslan
approved these changes
Sep 22, 2023
xDimon
requested changes
Sep 26, 2023
|
|
||
| crypto::EcdsaPrehashedMessage digest; | ||
| std::copy(msg.begin(), msg.end(), digest.begin()); | ||
| auto message = |
Member
There was a problem hiding this comment.
Can we avoid redundant copying here?
Comment on lines
+6
to
+7
| #ifndef KAGOME_DUMMY_PRUNER_HPP | ||
| #define KAGOME_DUMMY_PRUNER_HPP |
Member
There was a problem hiding this comment.
We agreed to replace include-guards by pragma-once while file changed. Lets do it for affected header-files.
| "./kusama-para-code/"; | ||
|
|
||
| constexpr std::string_view kRococoParachains[] = { | ||
| "01165a749e9bb0c9cdceec7745cdf2693fee68bce0a4de583488c4af5643bbdd.wasm", |
Member
There was a problem hiding this comment.
Do we need to distribute this .wasm files as well?
Contributor
Author
There was a problem hiding this comment.
Not really. Added parachain_runtimes/README.md and required scripts to produce those files locally on demand.
kamilsa
reviewed
Sep 26, 2023
| offchain_worker_pool | ||
| runtime_properties_cache | ||
| logger_for_tests | ||
| ) No newline at end of file |
Signed-off-by: Igor Egorov <igor@qdrvm.io>
xDimon
approved these changes
Sep 29, 2023
Comment on lines
+329
to
+330
| // "03170a2e7597b7b7e3d84c05391d139a62b157e78786d8c082f29dcf4c111314.wasm", | ||
| // // zero size |
Member
There was a problem hiding this comment.
Suggested change
| // "03170a2e7597b7b7e3d84c05391d139a62b157e78786d8c082f29dcf4c111314.wasm", | |
| // // zero size | |
| // // zero size | |
| // "03170a2e7597b7b7e3d84c05391d139a62b157e78786d8c082f29dcf4c111314.wasm", |
Comment on lines
+393
to
+394
| // "ae85d245a3d00bfde01f59f3c4fe0b4bfae1cb37e9cf91929eadcea4985711de.wasm", | ||
| // // zero size |
Member
There was a problem hiding this comment.
Suggested change
| // "ae85d245a3d00bfde01f59f3c4fe0b4bfae1cb37e9cf91929eadcea4985711de.wasm", | |
| // // zero size | |
| // // zero size | |
| // "ae85d245a3d00bfde01f59f3c4fe0b4bfae1cb37e9cf91929eadcea4985711de.wasm", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced issues
Resolves #1772
Description of the Change
Corrected implementation of:
Added WAVM stubs for:
Usage Examples or Tests
wavm_module_init_testfor testing local copies of runtimes