Skip to content

Case insensitive args#2434

Open
kamilsa wants to merge 3 commits intomasterfrom
update/case-insensitive-args
Open

Case insensitive args#2434
kamilsa wants to merge 3 commits intomasterfrom
update/case-insensitive-args

Conversation

@kamilsa
Copy link
Copy Markdown
Contributor

@kamilsa kamilsa commented Apr 11, 2025

Referenced issues

None

Description of the Change

Case insensitive args for better compatibility with Polkadot-SDK

Possible Drawbacks

None

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@kamilsa kamilsa requested review from Copilot, igor-egorov and xDimon and removed request for igor-egorov April 11, 2025 10:17
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Harrm
Copy link
Copy Markdown
Contributor

Harrm commented Apr 11, 2025

Should all CLI parameter string values be case-insensitive or just some of them?

@kamilsa
Copy link
Copy Markdown
Contributor Author

kamilsa commented Apr 11, 2025

Should all CLI parameter string values be case-insensitive or just some of them?

@Harrm the ones that are lower case in Polkadot-SDK should be case insensitive (so that both new users with Polkadot-SDK background are happy and our scripts keep working)

@kamilsa kamilsa marked this pull request as ready for review April 21, 2025 07:14
@kamilsa kamilsa requested review from Harrm and xDimon and removed request for igor-egorov April 21, 2025 07:15
@kamilsa kamilsa enabled auto-merge (squash) April 21, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants