Conversation
…execution benchmark
There was a problem hiding this comment.
Pull Request Overview
This PR updates the forked zlibe project to build correctly on the latest Mac clang 17, addressing compatibility issues in the benchmarking code.
- Removed the unnecessary fmt/chrono.h include.
- Updated the logging statement to output the nanosecond count explicitly.
Files not reviewed (2)
- cmake/Hunter/config.cmake: Language not supported
- cmake/Hunter/hunter-gate-url.cmake: Language not supported
Harrm
approved these changes
Apr 24, 2025
xDimon
approved these changes
Apr 26, 2025
core/storage/rocksdb/rocksdb.cpp
Outdated
Comment on lines
+170
to
+184
| // Print size of each column family | ||
| SL_INFO(log, "RocksDB column family sizes:"); | ||
| for (size_t i = 0; i < rocks_db->column_family_handles_.size(); i++) { | ||
| auto handle = rocks_db->column_family_handles_[i]; | ||
| std::string size_str; | ||
| if (rocks_db->db_->GetProperty( | ||
| handle, "rocksdb.estimate-live-data-size", &size_str)) { | ||
| uint64_t size_bytes = std::stoull(size_str); | ||
| double size_mb = static_cast<double>(size_bytes) / (1024 * 1024); | ||
| SL_INFO( | ||
| log, "Column family '{}': {:.2f} MB", handle->GetName(), size_mb); | ||
| } else { | ||
| SL_WARN( | ||
| log, "Failed to get size of column family '{}'", handle->GetName()); | ||
| } |
Member
There was a problem hiding this comment.
Should we keep this code? Looks like one-time debugging code.
kamilsa
added a commit
that referenced
this pull request
Jun 10, 2025
* Update to hunter with updated default zlib (cherry picked from commit 3f8b2c0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Necessary updates to build on latest Mac clang 17
Possible Drawbacks
None
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: