chore: bump action runtime to node24#177
Open
davehenton wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
Aligns the .node-version files and release workflow's setup-node with the action runtime declared in action.yml so tests run on the same Node version we ship under. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
petrsvihlik
approved these changes
May 7, 2026
davehenton
added a commit
to qltysh/qlty
that referenced
this pull request
May 8, 2026
Bumps the coverage upload step to qltysh/qlty-action@f071a76 to validate the node24 runtime migration (qltysh/qlty-action#177) against a real CI workflow before we cut a release. ## Test plan - [ ] CI run is green - [ ] No "Node.js 20 actions are deprecated" warning naming qltysh/qlty-action/coverage in the run logs Will repin to `@v2` (or a new tag) once qltysh/qlty-action#177 merges and ships.
Contributor
|
Also requested here: #175 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
using: node20→using: node24incoverage/action.yml,fmt/action.yml, andinstall/action.yml..node-versionfiles andrelease.yml'ssetup-nodestep, so tests run under the same Node version we ship under.node20actions tonode24on June 2, 2026.Scope
Action runtime + matching build/test toolchain. Out of scope:
actions/checkout@v4/actions/setup-node@v4in our own CI workflows still warn on node20 — separate cleanup, doesn't affect customers.engines.nodein package.json files left at>=20(permissive minimum, satisfied by 24).Test plan
npm run allin each workspace under local Node 24.15.0 — typecheck clean, 91 tests pass, esbuild bundles producedUpload coverage,Complete coverage,Run fmt actionall executed under node24 runtimeCloses #176