Retrieve the commit SHA as the reference for pull requests#23
Open
dejan-lukic wants to merge 1 commit intoqltysh:mainfrom
Open
Retrieve the commit SHA as the reference for pull requests#23dejan-lukic wants to merge 1 commit intoqltysh:mainfrom
dejan-lukic wants to merge 1 commit intoqltysh:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances reference resolution by first attempting to extract the current pull request’s commit SHA from the page’s details-menu and falling back to URL-based refs, and updates the coverage loader to use the new reference parameter.
- Introduce
getRef,getPullRequestCommitSha, andgetRefFromUrlto resolve the correct Git reference - Update
loadCoverageForPathto pass the resolved ref intoreadCoverageData - Change
readCoverageDatasignature to accept an explicit reference and remove inline URL parsing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/github.ts | Add commit SHA extraction, URL fallback logic, and ref lookup |
| src/api.ts | Update readCoverageData to take a reference parameter |
Comments suppressed due to low confidence (1)
src/github.ts:13
- [nitpick] Add unit tests for the new
getRef,getPullRequestCommitSha, andgetRefFromUrlfunctions to verify correct behavior across different page states (e.g., PR view, commit view, and non-PR pages).
function getRef() {
27946e3 to
9175d65
Compare
9175d65 to
a125502
Compare
a125502 to
a47ba72
Compare
…ts, as refs/pull/{number} does not yield results from the qlty.sh API
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The qlty.sh api does not yield coverage results for references in the format
refs/pull/{number}.This PR instead retrieves the commit SHA for the currently viewed PR via the
Changes from...element (see screenshot) on the page. Alternatively, we could (and probably should) use a more robust method to retrieve the SHA, e.g. via the GitHub API