fix: enable qlty-ignore comments for structure issues#2492
fix: enable qlty-ignore comments for structure issues#2492marschattha wants to merge 4 commits intomainfrom
Conversation
|
No issue mentions found. Please mention an issue in the pull request description. Use GitHub automation to close the issue when a PR is merged |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for inline issue muting using qlty-ignore comments in the structure smell checker. The key changes involve moving shared functionality to common locations and integrating issue transformation logic into the structure analysis pipeline.
- Moves
SourceReadertrait andIssueMuterfromqlty-checktoqlty-analysisfor shared use - Adds transformer support to the structure smell detection pipeline to apply ignore rules, triages, and deprecated overrides
- Introduces a
Workspaceabstraction inqlty-smellsto handle source file reading with proper path resolution
Reviewed Changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| qlty-analysis/src/source_reader.rs | Moved from qlty-check; provides trait and filesystem implementation for reading source files |
| qlty-analysis/src/issue_muter.rs | Moved from qlty-check; implements inline comment-based issue suppression using tree-sitter |
| qlty-smells/src/structure/workspace.rs | New workspace abstraction for path-aware source reading in structure checker |
| qlty-smells/src/structure/planner.rs | Extended to compute issue transformers including ignore rules, muting, and triage logic |
| qlty-smells/src/structure/plan.rs | Added transformers field to store issue transformation pipeline |
| qlty-smells/src/structure/executor.rs | Applies transformers to issues after checking |
| qlty-check/src/planner.rs | Updated import to use moved IssueMuter from qlty-analysis |
| qlty-cli/tests/cmd/smells/structure.in/returns.js | Test file updated with qlty-ignore comment |
| qlty-cli/tests/cmd/smells/structure.stdout | Expected test output reflecting ignored function parameters issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 new issues
|
|
Diff Coverage for ubuntu-latest: The code coverage on the diff in this pull request is 67.9%. Total Coverage for ubuntu-latest: This PR will decrease coverage by 0.02%. File Coverage Changes
🛟 Help
|
|
Diff Coverage for macos-15: The code coverage on the diff in this pull request is 67.9%. Total Coverage for macos-15: This PR will decrease coverage by 0.02%. File Coverage Changes
🛟 Help
|
No description provided.