refactor: Add basic transformations for check, smells and build commands by marschattha · Pull Request #2493 · qltysh/qlty

marschattha · 2025-10-29T15:40:39Z

No description provided.

github-actions · 2025-10-29T15:40:49Z

No issue mentions found. Please mention an issue in the pull request description.

Use GitHub automation to close the issue when a PR is merged

Copilot

Pull Request Overview

This pull request refactors the issue transformation system by:

Changing transform_batch signature to accept a reference (&Vec<Issue>) instead of taking ownership
Moving shared transformation logic (IssueMuter, triage handling, ignore rules) into a new BasicTransformations trait in qlty-analysis
Moving source_reader and issue_muter modules from qlty-check to qlty-analysis for better code organization
Applying basic transformations consistently across check, build, and smells commands
Updating test expectations to reflect new triage behavior affecting issue ordering

Reviewed Changes

Copilot reviewed 24 out of 26 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
qlty-config/src/config/issue_transformer.rs	Updated trait and tests to use reference parameter
qlty-check/src/report.rs	Implemented BasicTransformations trait
qlty-check/src/planner.rs	Removed duplicate triage/muter logic now in BasicTransformations
qlty-check/src/lib.rs	Removed modules moved to qlty-analysis
qlty-check/src/llm/fixer.rs	Updated signature to match trait
qlty-check/src/executor.rs	Updated call site to pass reference
qlty-analysis/src/basic_transformations.rs	New trait centralizing transformation logic
qlty-analysis/src/source_reader.rs	Moved from qlty-check
qlty-analysis/src/issue_muter.rs	Moved from qlty-check with minor formatting updates
qlty-analysis/src/workspace_reader.rs	New wrapper for workspace-level file reading
qlty-analysis/src/report.rs	Implemented BasicTransformations trait with commented-out duplicate code
qlty-cli/src/commands/*.rs	Applied basic transformations to reports
Test files	Updated expectations for new behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-29T15:43:34Z

qlty-config/src/config/issue_transformer.rs

    }

-    fn transform_batch(&self, issues: Vec<Issue>) -> Vec<Issue> {
+    fn transform_batch(&self, issues: &Vec<Issue>) -> Vec<Issue> {


The parameter type &Vec<Issue> should be &[Issue] instead. Using a slice reference is more idiomatic in Rust as it's more flexible (accepts both Vec and array references) and is the standard convention for borrowed sequences.

Suggested change

fn transform_batch(&self, issues: &Vec<Issue>) -> Vec<Issue> {

fn transform_batch(&self, issues: &[Issue]) -> Vec<Issue> {

Copilot · 2025-10-29T15:43:35Z

qlty-check/src/llm/fixer.rs


 impl IssueTransformer for Fixer {
-    fn transform_batch(&self, issues: Vec<Issue>) -> Vec<Issue> {
+    fn transform_batch(&self, issues: &Vec<Issue>) -> Vec<Issue> {


The parameter type &Vec<Issue> should be &[Issue] instead. Using a slice reference is more idiomatic in Rust as it's more flexible (accepts both Vec and array references) and is the standard convention for borrowed sequences.

Suggested change

fn transform_batch(&self, issues: &Vec<Issue>) -> Vec<Issue> {

fn transform_batch(&self, issues: &[Issue]) -> Vec<Issue> {

Copilot · 2025-10-29T15:43:35Z

qlty-analysis/src/report.rs

+    //             });
+    //         }
+    //     }
+
+    //     triages
+    // }
+
+    // pub fn apply_basic_issue_transformations(
+    //     &mut self,
+    //     workspace_root: &Path,
+    //     qlty_config: &QltyConfig,
+    // ) {
+    //     // Remove issues without location
+    //     let transformers = self.compute_transformers(workspace_root, qlty_config);
+    //     for transformer in transformers {
+    //         self.transform_issues(transformer);
+    //     }
+    // }
+


Remove commented-out code. This large block of commented code (lines 37-106) appears to be duplicate logic that was moved to BasicTransformations trait. Commented code should be removed to improve maintainability; the old implementation can be retrieved from version control if needed.

Suggested change

// });

// }

// }

// triages

// }

// pub fn apply_basic_issue_transformations(

// &mut self,

// workspace_root: &Path,

// qlty_config: &QltyConfig,

// ) {

// // Remove issues without location

// let transformers = self.compute_transformers(workspace_root, qlty_config);

// for transformer in transformers {

// self.transform_issues(transformer);

// }

// }

qltysh · 2025-10-29T15:44:22Z

1 new issue

Tool	Category	Rule	Count
qlty	Structure	High total complexity (count = 59)	1

qlty-check/src/lib.rs

qltysh · 2025-10-29T15:47:24Z

Diff Coverage for ubuntu-latest: The code coverage on the diff in this pull request is 95.7%.

Total Coverage for ubuntu-latest: This PR will decrease coverage by 0.03%.

File Coverage Changes

Path	File Coverage Δ	Indirect
qlty-analysis/src/basic_transformations.rs	100.0
qlty-analysis/src/issue_muter.rs	97.2
qlty-analysis/src/report.rs	2.3
qlty-analysis/src/source_reader.rs	100.0	√
qlty-analysis/src/workspace_reader.rs	76.9
qlty-check/src/executor/driver.rs	-0.2	√
qlty-check/src/issue_muter.rs	-99.1	√
qlty-check/src/planner.rs	-1.3
qlty-check/src/report.rs	1.4
qlty-check/src/source_reader.rs	-100.0	√
qlty-cli/src/auth/auth_flow.rs	-0.6	√
qlty-cli/src/commands/build.rs	0.0
qlty-cli/src/commands/check.rs	0.2
qlty-cli/src/commands/smells.rs	0.1
qlty-config/src/config/ignore.rs	6.1	√
qlty-config/src/config/triage.rs	-13.2	√
qlty-coverage/src/ci/github.rs	-0.3	√
qlty-types/src/lib.rs	-0.4	√

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

qltysh · 2025-10-29T15:48:19Z

Diff Coverage for macos-15: The code coverage on the diff in this pull request is 95.7%.

Total Coverage for macos-15: This PR will decrease coverage by 0.03%.

File Coverage Changes

Path	File Coverage Δ	Indirect
qlty-analysis/src/basic_transformations.rs	100.0
qlty-analysis/src/issue_muter.rs	97.2
qlty-analysis/src/report.rs	26.7
qlty-analysis/src/source_reader.rs	100.0	√
qlty-analysis/src/workspace_reader.rs	76.9
qlty-check/src/executor/driver.rs	-0.2	√
qlty-check/src/issue_muter.rs	-99.1	√
qlty-check/src/planner.rs	-1.3
qlty-check/src/report.rs	1.4
qlty-check/src/source_reader.rs	-100.0	√
qlty-cli/src/commands/build.rs	0.0
qlty-cli/src/commands/check.rs	0.2
qlty-cli/src/commands/smells.rs	0.1
qlty-config/src/config/ignore.rs	6.1	√
qlty-config/src/config/triage.rs	-13.2	√
qlty-config/src/library.rs	-0.5	√
qlty-coverage/src/ci/github.rs	-0.3	√
qlty-types/src/lib.rs	-0.4	√

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

refactor: Add basic transformations for check, smells and build commands

aa40b5a

Copilot AI review requested due to automatic review settings October 29, 2025 15:40

Merge branch 'main' into ma/add_basic_transformations_for_commands

cb0d7b9

Copilot AI reviewed Oct 29, 2025

View reviewed changes

fix merge confict

4a436d4

qltysh bot reviewed Oct 29, 2025

View reviewed changes

qlty-check/src/lib.rs Outdated Show resolved Hide resolved

qltysh bot reviewed Oct 29, 2025

View reviewed changes

qlty-check/src/lib.rs Outdated Show resolved Hide resolved

cleanup

bf13f74

marschattha requested a review from brynary October 30, 2025 13:16

bruno-garcia mentioned this pull request Mar 9, 2026

chore(bots): remove qlty — static analysis bot, not AI code review bruno-garcia/code-review-trends#249

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Add basic transformations for check, smells and build commands#2493

refactor: Add basic transformations for check, smells and build commands#2493
marschattha wants to merge 4 commits intomainfrom
ma/add_basic_transformations_for_commands

marschattha commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

qltysh bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

qltysh bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

qltysh bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	fn transform_batch(&self, issues: &Vec<Issue>) -> Vec<Issue> {
	fn transform_batch(&self, issues: &[Issue]) -> Vec<Issue> {

Conversation

marschattha commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 new issue

Uh oh!

Uh oh!

Uh oh!

qltysh bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

qltysh bot commented Oct 29, 2025 •

edited

Loading

qltysh bot commented Oct 29, 2025 •

edited

Loading

qltysh bot commented Oct 29, 2025 •

edited

Loading