[Bug] Reference to layer lost when uploading keymap generated with c2json (layer enum)

[dawosch]

Describe the Bug

When you generate a keymap.json file from your keymap.c file with the qmk c2json command and you upload this keymap to the config.qmk.fm configurator the layer key references are lost.

This happens when you are using a enum for layers.
E.g.

enum layers {
  QWERTY = 0,
  COLMAK
}

...

[QWERTY] = LAYOUT(
  DF(COLMAK), ...
)

...

[COLMAK] = LAYOUT(
  DF(QWERTY), ...
)

This results in an keymap which look like this:

...
"layers": [
  [ DF(COLMAK), ... ],
  [ DF(QWERTY), ... ]
]
...

Because the Enum layer names are not converted to its indices and the layer names are not exported the reference will be lost.

I created an issue and a pull request within the qmk_firmware, but right now nobody cares.
Maybe someone of you have the same problem?

Here is the issue: Issue
Here is the PR: PR

Additional Context?

No response

[tzarc]

We talked about this internally but seemingly nobody responded. Sorry about that.

qmk c2json is only intended to be used in very niche cases -- it's specifically documented that it doesn't work with many keymaps especially if they're using preprocessor to deal with keycodes and/or layers. This note should probably be extended to enum as well -- we generally consider the conversion from JSON to C a one-way operation.

For the most part qmk c2json is really only used to populate the default keymaps within qmk_configurator itself, which does not work with layer naming information.

[dawosch]

Ok, thank you for your feedback.
The only thing i want to note is that qmk knows about the layer names, as you can see in my pull request.
So the change is minimal and would give users the ability to export these.

Maybe for context.
I created a web application for learning new layouts. And right now i can't resolve the layer names to its indices and have to show the names instead.
And my PR would help me (and so all users) to learn new layouts better.
I don't want to promote my project and you can remove the link if not wanted, but it shows the usecase i have.

The Project: Interactive KBD