Conversation
| "vid": "0x1001" | ||
| }, | ||
| "layouts": { | ||
| "LAYOUT_all": { |
There was a problem hiding this comment.
This is not really correct for a LAYOUT_all:
It looks like the LAYOUT_225u_1u_275u is more appropriate for a configuration with all matrix positions available:
This layout should be renamed to LAYOUT_all, and the current LAYOUT_all removed.
There was a problem hiding this comment.
If you look at the actual switches, the current LAYOUT_all is the only one that gives you access to every switch. This allows the default keymap to work all the layouts which is what the manufacturer wants. If you type qmk info -l you can see that.
E.g.
LAYOUT_275u_225u is missing sw38, sw40, and sw42
LAYOUT_7u is missing sw38, sw39, sw41, and sw42
LAYOUT_225u_1u_275u is missing sw39 and sw41
There was a problem hiding this comment.
@waffle87 Did I correctly understand your post? Do you still think LAYOUT_all is incorrect?
| ], | ||
| "keyboard": "aokay/mid1", | ||
| "keymap": "default", | ||
| "layout": "LAYOUT_all", |
There was a problem hiding this comment.
The keymap should be updated appropriately to reflect the changes from the above suggestion.
| }, | ||
| "features": { | ||
| "bootmagic": true, | ||
| "encoder": true, |
There was a problem hiding this comment.
Is it correct to assume the encoder push button functionality is not connected and not part of the switch matrix?
There was a problem hiding this comment.
That is correct. The encoders are not part of the switch matrix and they have no push button functionality.
3 participants
Add a new keyboard maker A.Okay! (keyboards/aokay/) and a new keyboard Mid.1 (keyboards/aokay/mid1/).
Description
Added keyboards/aokay/mid1/ along with readme and .json files. No .c or .h or other files were needed.
Types of Changes
Issues Fixed or Closed by This PR
Checklist