Implement num lock light for Keychron V5#26019
Open
toast003 wants to merge 3 commits intoqmk:masterfrom
Open
Conversation
zvecr
requested changes
Feb 25, 2026
|
|
||
| #endif // DIP_SWITCH_ENABLE | ||
|
|
||
| #if defined(RGB_MATRIX_ENABLE) && defined(CAPS_LOCK_LED_INDEX) |
Member
There was a problem hiding this comment.
Your PR will not function correctly as this line needs to be:
#if defined(RGB_MATRIX_ENABLE) && (defined(CAPS_LOCK_LED_INDEX) || defined(NUM_LOCK_LED_INDEX))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make this work
NUM_LOCK_LED_INDEXneeds to be defined, I haven't done so in this PR since I'm not sure if it would be better to do it on a separate oneDescription
This PR makes it so that the backlight for the num lock key turns white when num lock is active, just like caps lock.
Types of Changes
Issues Fixed or Closed by This PR
Checklist