fix: prevent KeyError when removing type from PR description data

[wishhyt]

Summary

• When enable_pr_type is False, self.data.pop('type') raises KeyError if the AI response YAML does not contain a type field
• This is inconsistent with the adjacent labels removal which guards with if 'labels' in self.data before popping
• Use pop('type', None) for safe removal

Changes

pr_agent/tools/pr_description.py: Changed self.data.pop('type') to self.data.pop('type', None)

Test plan

• Verify that /describe works correctly when enable_pr_type is False and AI response omits the type field
• Verify normal behavior when type field is present

[qodo-free-for-open-source-projects]

Review Summary by Qodo

Prevent KeyError when removing type from PR description

🐞 Bug fix

Walkthroughs

Description

• Prevent KeyError when removing type field from PR description
• Use safe pop with default None value for consistency
• Handles cases where AI response omits type field

Diagram

flowchart LR
  A["enable_pr_type is False"] -- "type field missing" --> B["pop without default"]
  B -- "raises KeyError" --> C["Error"]
  A -- "type field missing" --> D["pop with None default"]
  D -- "returns None safely" --> E["Success"]

Loading

File Changes

1. pr_agent/tools/pr_description.py 🐞 Bug fix +1/-1

Safe removal of optional type field

• Changed self.data.pop('type') to self.data.pop('type', None)
• Prevents KeyError when type field is absent from AI response
• Aligns with existing safe removal pattern for labels field

pr_agent/tools/pr_description.py

---

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more