fix: close file descriptor after writing temp settings file

[wishhyt]

Summary

• tempfile.mkstemp() returns an open file descriptor that was never closed after os.write()
• The finally block removes the temp file with os.remove() but does not close the fd
• In a long-running server process, each call to apply_repo_settings() leaks one file descriptor, eventually exhausting the system fd limit

Changes

pr_agent/git_providers/utils.py: Added os.close(fd) after os.write(fd, repo_settings)

Test plan

• Verify that repo settings are still applied correctly after the change
• Verify no file descriptor leak by monitoring fd count across multiple settings applications

[qodo-free-for-open-source-projects]

Review Summary by Qodo

Close file descriptor after writing temp settings file

🐞 Bug fix

Walkthroughs

Description

• Close file descriptor after writing temp settings file
• Prevents file descriptor leak in long-running server processes
• Fixes exhaustion of system fd limit on repeated settings applications

Diagram

flowchart LR
  A["tempfile.mkstemp returns open fd"] --> B["os.write writes to fd"]
  B --> C["os.close closes fd"]
  C --> D["finally block removes temp file"]
  D --> E["No fd leak"]

Loading

File Changes

1. pr_agent/git_providers/utils.py 🐞 Bug fix +1/-0

Close file descriptor after write operation

• Added os.close(fd) call after os.write(fd, repo_settings) to properly close the file
 descriptor
• Prevents file descriptor leak in apply_repo_settings() function
• Ensures long-running server processes don't exhaust system file descriptor limits

pr_agent/git_providers/utils.py

---

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0)

1. fd not closed on error 📘 Rule violation ⛯ Reliability

Description

The new os.close(fd) is not protected by a finally, so an exception from `os.write(fd,
repo_settings)` can still leak the file descriptor. This does not fully meet the robust
error-handling requirement for cleanup on failure paths.

Code

pr_agent/git_providers/utils.py[R37-39]

                    fd, repo_settings_file = tempfile.mkstemp(suffix='.toml')
                    os.write(fd, repo_settings)
+                    os.close(fd)

Evidence

PR Compliance ID 3 requires anticipating and handling error scenarios; here, os.close(fd) occurs
only after os.write(...) succeeds, so the error path is not handled for descriptor cleanup.

Rule 3: Robust Error Handling
pr_agent/git_providers/utils.py[37-39]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`os.close(fd)` is executed only if `os.write(fd, repo_settings)` succeeds; if `os.write` raises, the file descriptor can still leak.

## Issue Context
This code uses `tempfile.mkstemp()` which returns a raw OS file descriptor that must be closed on all paths (success and exception).

## Fix Focus Areas
- pr_agent/git_providers/utils.py[37-39]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[qodo-free-for-open-source-projects]

1. fd not closed on error 📘 Rule violation ⛯ Reliability

The new os.close(fd) is not protected by a finally, so an exception from `os.write(fd,
repo_settings)` can still leak the file descriptor. This does not fully meet the robust
error-handling requirement for cleanup on failure paths.

Agent Prompt

## Issue description
`os.close(fd)` is executed only if `os.write(fd, repo_settings)` succeeds; if `os.write` raises, the file descriptor can still leak.

## Issue Context
This code uses `tempfile.mkstemp()` which returns a raw OS file descriptor that must be closed on all paths (success and exception).

## Fix Focus Areas
- pr_agent/git_providers/utils.py[37-39]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools