chore(erratic): improve error handling capabilities #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several key improvements to the `erratic` package: - **Stack Trace Capture:** The `New` function now automatically captures the stack frame where the error is created, providing valuable debugging information. - **Slog Integration:** Implemented `slog.LogValuer` for `QuantmError`, allowing for structured logging of error details. - **Hint Type Flexibility:** The `Hints` type in `internal/erratic/hints.go` has been changed from `map[string]string` to `map[string]any`, enabling the storage of non-string values as hints. - **Proto/Connect Error Stringification:** When converting errors to proto or Connect errors, hints are now stringified to ensure compatibility. - **New Test Cases:** Added comprehensive unit tests for the `QuantmError` type, covering hint handling, stack trace scenarios, and the `New` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several key improvements to the
erraticpackage:Newfunction now automatically captures the stack frame where the error is created, providing valuable debugging information.slog.LogValuerforQuantmError, allowing for structured logging of error details.Hintstype ininternal/erratic/hints.gohas been changed frommap[string]stringtomap[string]any, enabling the storage of non-string values as hints.QuantmErrortype, covering hint handling, stack trace scenarios, and theNewfunction.