Conversation
xstefank
approved these changes
Nov 26, 2025
|
|
||
| @Override | ||
| public String resourceId() { | ||
| return getName(); |
Member
There was a problem hiding this comment.
this could just directly return field but no biggie
Member
Author
There was a problem hiding this comment.
This is meant to show that the logic associated with getting the name is the logic needed for the resource id. In this case, it's the same but it might end up being different than just returning the field at some point.
Member
There was a problem hiding this comment.
Then maybe add a comment with this? I think it might be important for someone checking this sample.
metacosm
force-pushed
the
update-josdk
branch
from
3ee947b to
71748e4
Compare
xstefank
approved these changes
Dec 1, 2025
|
|
||
| @Override | ||
| public String resourceId() { | ||
| return getName(); |
Member
There was a problem hiding this comment.
Then maybe add a comment with this? I think it might be important for someone checking this sample.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.